hide game levels in the view, #165

phetsims · Aug 22, 2021 · 4ad3f56 · 4ad3f56
1 parent d6273e2
commit 4ad3f56
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/js/solveit/model/SolveItModel.js b/js/solveit/model/SolveItModel.js
@@ -7,7 +7,6 @@
  */
 
 import Property from '../../../../axon/js/Property.js';
-import EqualityExplorerQueryParameters from '../../common/EqualityExplorerQueryParameters.js';
 import equalityExplorer from '../../equalityExplorer.js';
 import ChallengeGenerator1 from './ChallengeGenerator1.js';
 import ChallengeGenerator2 from './ChallengeGenerator2.js';
@@ -33,14 +32,6 @@ class SolveItModel {
     assert && assert( _.every( this.challengeGenerators, ( value, index, array ) => ( index === 0 || array[ index - 1 ].level <= value.level ) ),
       'Challenge generators must be ordered by ascending level number.' );
 
-    // Filter challenge generators by gameLevels query parameter.
-    // See https://github.com/phetsims/equality-explorer/issues/165
-    if ( EqualityExplorerQueryParameters.gameLevels ) {
-      this.challengeGenerators = _.filter( this.challengeGenerators, challengeGenerator =>
-        EqualityExplorerQueryParameters.gameLevels.includes( challengeGenerator.level )
-      );
-    }
-
     // @public (read-only) {SolveItScene[]} a scene for each challenge generator
     this.scenes = _.map( this.challengeGenerators, challengeGenerator => new SolveItScene( challengeGenerator ) );
 

diff --git a/js/solveit/view/LevelSelectionNode.js b/js/solveit/view/LevelSelectionNode.js
@@ -19,6 +19,7 @@ import Text from '../../../../scenery/js/nodes/Text.js';
 import RectangularPushButton from '../../../../sun/js/buttons/RectangularPushButton.js';
 import Dialog from '../../../../sun/js/Dialog.js';
 import EqualityExplorerConstants from '../../common/EqualityExplorerConstants.js';
+import EqualityExplorerQueryParameters from '../../common/EqualityExplorerQueryParameters.js';
 import equalityExplorer from '../../equalityExplorer.js';
 import equalityExplorerStrings from '../../equalityExplorerStrings.js';
 import EqualityExplorerLevelSelectionButton from './EqualityExplorerLevelSelectionButton.js';
@@ -42,12 +43,22 @@ class LevelSelectionNode extends Node {
       maxWidth: 0.65 * layoutBounds.width
     };
 
-    // Level-selection buttons
+    // Level-selection buttons, ordered by ascending level number.
     const levelSelectionButtons = [];
     model.scenes.forEach( scene => {
       levelSelectionButtons.push( new EqualityExplorerLevelSelectionButton( scene, model.sceneProperty ) );
     } );
 
+    // Hide buttons for levels that are not included in gameLevels query parameter.
+    // We must still create these buttons so that we don't change the PhET-iO API.
+    // See https://github.com/phetsims/equality-explorer/issues/165
+    if ( EqualityExplorerQueryParameters.gameLevels ) {
+      for ( let i = 0; i < levelSelectionButtons.length; i++ ) {
+        const levelNumber = i + 1;
+        levelSelectionButtons[ i ].visible = EqualityExplorerQueryParameters.gameLevels.includes( levelNumber );
+      }
+    }
+
     // Layout the level-selection buttons horizontally
     const levelSelectionButtonsBox = new HBox( {
       children: levelSelectionButtons,