Skip to content

Commit

Permalink
revise implementation-notes.md for #179
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Oct 4, 2021
1 parent eb0e6ca commit b1e9746
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions doc/implementation-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,13 @@ Keyboard navigation is implemented. Look for these "markers" to identify related
pressing the keyboard button in the navigation bar.
* If all else fails, search for `// pdom`, which generally appears before code that is specific to a11y.

User-interface sounds are implemented, and most of the sounds are provided by common-code UI components. There are
2 exceptions to user-interface sounds: (1) As of this writing, the amplitude sliders in the **Discrete** screen have temporary sound support (see [AudibleSlider.js](https://github.com/phetsims/fourier-making-waves/blob/master/js/common/view/AudibleSlider.js)).
Other sliders in the sim do not support sound, due to lack of support in Slider.js.
(2) Measurement Tools do not currently have associated sounds, as discussed in https://github.com/phetsims/fourier-making-waves/issues/169.
User-interface sounds are implemented, and most of the sounds are provided by common-code UI components. There are 2
exceptions to user-interface sounds: (1) As of this writing, the amplitude sliders in the **Discrete** and
**Wave Game** screens have temporary sound support
(
see [AmplitudeSlider.js](https://github.com/phetsims/fourier-making-waves/blob/master/js/common/view/AmplitudeSlider.js))
. Other sliders in the sim do not support sound, due to lack of support in Slider.js.
(2) Measurement Tools do not currently have associated sounds, as discussed
in https://github.com/phetsims/fourier-making-waves/issues/169.

Voicing and screen reader support are not implemented as of this writing.

0 comments on commit b1e9746

Please sign in to comment.