add back ability to hide individual temperature list box items, see #345

phetsims · Aug 18, 2023 · 75876e9 · 75876e9
1 parent 232ab81
commit 75876e9
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/js/common/view/ThermometerAndReadout.ts b/js/common/view/ThermometerAndReadout.ts
@@ -120,19 +120,22 @@ class ThermometerAndReadout extends Node {
           kelvinUnitsStringProperty,
           temperatureInKelvinProperty,
           temperatureInKelvinProperty.range,
-          TemperatureUnits.KELVIN
+          TemperatureUnits.KELVIN,
+          `kelvin${ComboBox.ITEM_TANDEM_NAME_SUFFIX}`
         ),
         ThermometerAndReadout.createComboBoxItem(
           celsiusUnitsStringProperty,
           temperatureInCelsiusProperty,
           celsiusRange,
-          TemperatureUnits.CELSIUS
+          TemperatureUnits.CELSIUS,
+          `celsius${ComboBox.ITEM_TANDEM_NAME_SUFFIX}`
         ),
         ThermometerAndReadout.createComboBoxItem(
           fahrenheitUnitsStringProperty,
           temperatureInFahrenheitProperty,
           fahrenheitRange,
-          TemperatureUnits.FAHRENHEIT
+          TemperatureUnits.FAHRENHEIT,
+          `fahrenheit${ComboBox.ITEM_TANDEM_NAME_SUFFIX}`
         )
       ];
 
@@ -223,23 +226,24 @@ class ThermometerAndReadout extends Node {
   private static createComboBoxItem( unitsStringProperty: TReadOnlyProperty<string>,
                                      property: TReadOnlyProperty<number>,
                                      propertyRange: Range,
-                                     propertyValue: TemperatureUnits ): ComboBoxItem<TemperatureUnits> {
+                                     propertyValue: TemperatureUnits,
+                                     tandemName: string ): ComboBoxItem<TemperatureUnits> {
     return {
       value: propertyValue,
-      createNode: tandem => new NumberDisplay( property, propertyRange, {
+      createNode: () => new NumberDisplay( property, propertyRange, {
         backgroundStroke: null,
         decimalPlaces: DECIMAL_PLACES_IN_READOUT,
         textOptions: {
           font: GreenhouseEffectConstants.CONTENT_FONT,
           maxWidth: 120
         },
         valuePattern: new PatternStringProperty(
-          GreenhouseEffectStrings.temperature.units.valueUnitsPatternStringProperty, {
-            units: unitsStringProperty
-          }, { tandem: tandem.createTandem( 'valuePatternStringProperty' ) } ),
-        tandem: tandem,
+          GreenhouseEffectStrings.temperature.units.valueUnitsPatternStringProperty,
+          { units: unitsStringProperty }
+        ),
         phetioVisiblePropertyInstrumented: false
       } ),
+      tandemName: tandemName,
       a11yName: TemperatureDescriber.getTemperatureUnitsString( propertyValue )
     };
   }