uninstrument some text elements, see #341

phetsims · Aug 7, 2023 · fb1d6c1 · fb1d6c1
1 parent e9a2082
commit fb1d6c1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 16 deletions.
diff --git a/js/common/model/PhotonAbsorbingEmittingLayer.ts b/js/common/model/PhotonAbsorbingEmittingLayer.ts
@@ -107,7 +107,7 @@ class PhotonAbsorbingEmittingLayer extends PhetioObject {
     const options = optionize<PhotonAbsorbingEmittingLayerOptions, SelfOptions, PhetioObjectOptions>()( {
       thickness: 0,
       photonMaxLateralJumpProportion: 0.01,
-      photonAbsorptionTime: 0.1,
+      photonAbsorptionTime: 5,
       absorbanceMultiplier: 1,
       phetioType: PhotonAbsorbingEmittingLayer.PhotonAbsorbingEmittingLayerIO,
 

diff --git a/js/common/view/ThermometerAndReadout.ts b/js/common/view/ThermometerAndReadout.ts
@@ -120,22 +120,19 @@ class ThermometerAndReadout extends Node {
           kelvinUnitsStringProperty,
           temperatureInKelvinProperty,
           temperatureInKelvinProperty.range,
-          TemperatureUnits.KELVIN,
-          `kelvin${ComboBox.ITEM_TANDEM_NAME_SUFFIX}`
+          TemperatureUnits.KELVIN
         ),
         ThermometerAndReadout.createComboBoxItem(
           celsiusUnitsStringProperty,
           temperatureInCelsiusProperty,
           celsiusRange,
-          TemperatureUnits.CELSIUS,
-          `celsius${ComboBox.ITEM_TANDEM_NAME_SUFFIX}`
+          TemperatureUnits.CELSIUS
         ),
         ThermometerAndReadout.createComboBoxItem(
           fahrenheitUnitsStringProperty,
           temperatureInFahrenheitProperty,
           fahrenheitRange,
-          TemperatureUnits.FAHRENHEIT,
-          `fahrenheit${ComboBox.ITEM_TANDEM_NAME_SUFFIX}`
+          TemperatureUnits.FAHRENHEIT
         )
       ];
 
@@ -190,8 +187,7 @@ class ThermometerAndReadout extends Node {
           return units === TemperatureUnits.KELVIN ? kelvinUnitsString :
                  units === TemperatureUnits.CELSIUS ? celsiusUnitsString :
                  fahrenheitUnitsString;
-        },
-        { tandem: options.tandem.createTandem( 'unitsStringProperty' ) }
+        }
       );
 
       // Create the temperature readout.
@@ -230,8 +226,7 @@ class ThermometerAndReadout extends Node {
   private static createComboBoxItem( unitsStringProperty: TReadOnlyProperty<string>,
                                      property: TReadOnlyProperty<number>,
                                      propertyRange: Range,
-                                     propertyValue: TemperatureUnits,
-                                     tandemName: string ): ComboBoxItem<TemperatureUnits> {
+                                     propertyValue: TemperatureUnits ): ComboBoxItem<TemperatureUnits> {
     return {
       value: propertyValue,
       createNode: tandem => new NumberDisplay( property, propertyRange, {
@@ -248,7 +243,6 @@ class ThermometerAndReadout extends Node {
         tandem: tandem,
         phetioVisiblePropertyInstrumented: false
       } ),
-      tandemName: tandemName,
       a11yName: TemperatureDescriber.getTemperatureUnitsString( propertyValue )
     };
   }

diff --git a/js/layer-model/view/AtmosphereLayerNode.ts b/js/layer-model/view/AtmosphereLayerNode.ts
@@ -139,12 +139,13 @@ class AtmosphereLayerNode extends Node {
                      temperatureUnits === TemperatureUnits.KELVIN ? kelvinString :
                      temperatureUnits === TemperatureUnits.CELSIUS ? celsiusString :
                      fahrenheitString;
-            },
-            { tandem: options.tandem.createTandem( 'unitsStringProperty' ) }
+            }
           )
-        }, {
+        },
+        {
           tandem: temperatureReadoutTandem.createTandem( 'valuePatternStringProperty' )
-        } ),
+        }
+      ),
       tandem: temperatureReadoutTandem,
       decimalPlaces: 1,
       cornerRadius: 3,