Skip to content

Commit

Permalink
Uninstrument the About Dialog hyperlink strings, see #934
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Aug 17, 2023
1 parent 536b773 commit 2d9201f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/AboutDialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export default class AboutDialog extends Dialog {
// If links are allowed, use hyperlinks. Otherwise, just output the URL. This doesn't need to be internationalized.
const stringProperty = new DerivedStringProperty( [ allowLinksProperty, link.textStringProperty ], ( allowLinks, linkText ) => {
return allowLinks ? `<a href="{{url}}">${linkText}</a>` : `${linkText}: ${link.url}`;
}, { tandem: options.tandem.createTandem( `${link.tandemName}StringProperty` ) } );
} );

// This is PhET-iO instrumented because it is a keyboard navigation focusable element.
linksChildren.push( new RichText( stringProperty, {
Expand Down

0 comments on commit 2d9201f

Please sign in to comment.