Skip to content

Commit

Permalink
Use IReadOnlyProperty instead of DerivedProperty, see phetsims/axon#391
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Apr 22, 2022
1 parent 85cd7b6 commit cae927b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions js/sound-generators/SoundClipChord.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
*/

import DerivedProperty from '../../../axon/js/DerivedProperty.js';
import Property from '../../../axon/js/Property.js';
import merge from '../../../phet-core/js/merge.js';
import optionize from '../../../phet-core/js/optionize.js';
import SoundClip, { SoundClipOptions } from '../../../tambo/js/sound-generators/SoundClip.js';
import SoundGenerator, { SoundGeneratorOptions } from '../../../tambo/js/sound-generators/SoundGenerator.js';
import tambo from '../tambo.js';
import WrappedAudioBuffer from '../WrappedAudioBuffer.js';
import ISoundPlayer from '../ISoundPlayer.js';
import IReadOnlyProperty from '../../../axon/js/IReadOnlyProperty.js';

type SelfOptions = {

Expand Down Expand Up @@ -46,7 +46,7 @@ class SoundClipChord extends SoundGenerator implements ISoundPlayer {
private readonly playbackSoundClips: SoundClip[];

// flag indicating whether this is currently playing
public readonly isPlayingProperty: Property<boolean>;
public readonly isPlayingProperty: IReadOnlyProperty<boolean>;

constructor( sound: WrappedAudioBuffer, providedOptions?: SoundClipChordOptions ) {

Expand Down
2 changes: 1 addition & 1 deletion js/sound-generators/SoundGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import IReadOnlyProperty from '../../../axon/js/IReadOnlyProperty.js';
// constants
const DEFAULT_TIME_CONSTANT = soundConstants.DEFAULT_PARAM_CHANGE_TIME_CONSTANT;

let notSettingPhetioStateProperty: Property<boolean>;
let notSettingPhetioStateProperty: IReadOnlyProperty<boolean>;

export type SoundGeneratorOptions = {

Expand Down

0 comments on commit cae927b

Please sign in to comment.