-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alex/update ghc #11
alex/update ghc #11
Conversation
alexbiehl
commented
Jul 11, 2023
- Allow building with recent GHCs
- Test recent GHCs during CI
ecf3af0
to
e628e44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
with: | ||
cabal-version: latest | ||
ghc-version: ${{ matrix.ghc }} | ||
- run: cabal v2-test | ||
- run: cabal v2-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this mean the tests are no longer run at all? I mean it's debatable if running the tests should be a separate step, but they should definitely be run at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why I changed this to be build only 🤔 maybe it’d fail calling cabal test on a package that doesn’t have tests.
@alexbiehl Gentle ping to address the changes requested above. Your PR would allow users to use |
Merged and released as 0.4.4.0. |
@phile314 Thank you for making a release! Would you be able to update the Hackage metadata to allow base-4.19 (GHC 9.8)? I can already use pinch-gen with GHC 9.8 using the following clause in a
|
I took out the sledge hammer and increased the base upper limit to 5 😄 Let's see how this goes for the next few GHC releases. |
I greatly appreciate this, thank you! |