Make creating the table optional

[nodefortytwo]

It's pretty bad form to create cloud resources automatically, especially with such a generic default name.

I would make it default to false but that would change the existing behaviour to much

[philippgille]

Hi @nodefortytwo,

Thanks for the PR!

It's pretty bad form to create cloud resources automatically

Good point! I wanted it to be as easy as possible for users, including automatically creating the table so they wouldn't have to use the AWS dashboard, but didn't think about a flag to disable that. So with the default being true and your flag it's perfect in my opinion.

We can think about making false the default in the future, I don't mind breaking changes as long as the version is < 1.0.0, and with Go modules there shouldn't be issues with people accidentally getting a new version with a go get.

There's one syntax error though, I'll comment it in the PR code.

[philippgille]

trailing "," is missing here, see the Travis CI build: https://travis-ci.org/philippgille/gokv/jobs/638423386#L2320

[philippgille]

I think gofmt would add a space between the options.CreateTable and the {

[nodefortytwo]

Sorry you are right, i'll make those updates.

I did the change straight into github :)

i'll update later.

I am planning on a much bigger overhaul of this backend to add flexibility around role assumption and things like that (useful for lambdas) but i'll do that as a separate pr.

[philippgille]

I am planning on a much bigger overhaul of this backend to add flexibility around role assumption and things like that (useful for lambdas) but i'll do that as a separate pr

That sounds great! When I implemented this I didn't dig very deep into AWS and DynamoDB, so it's awesome if you have ideas for improvements and could even implement them!

Regarding the failing CI build: https://travis-ci.org/philippgille/gokv/jobs/639494585#L2596
=> The client created during the tests doesn't use the DefaultOptions (see

gokv/dynamodb/dynamodb_test.go

Line 231 in f277b58

options := dynamodb.Options{

), which is why false is used for CreateTable, now leading to these errors:

ResourceNotFoundException: Cannot do operations on a non-existent table

This also means that the PR would break existing code that doesn't use the DefaultOptions. But maybe that's okay, because 1) with Go modules or even a "previous generation package manager" or vendoring and a proper SemVer change in gokv this is acceptable, and 2) it's better to break by not creating a table anymore than the other way around.

The absolute safest option (no break at all) would be to change CreateTable to SkipCreateTable - that way the default value would be false and a client can use an empty Options struct or the DefaultOptions and the behavior would be the same.

What do you think?

[nodefortytwo]

Yeah agreed, thats a nice change, i'll update the PR tomorrow