SSO - Refresh hsdpamcookie to allow signle sign on between other Philips products #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-lafin
reviewed
Feb 1, 2024
…COOKIE_REFRESH_NAME' options
l-lafin
previously approved these changes
Feb 1, 2024
l-lafin
approved these changes
Feb 1, 2024
EriksonBahr
deleted the
rv/enable-oidc-single-sign-on-cookie-refresher
branch
3 tasks
evozniak
added a commit
that referenced
this pull request
Feb 2, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Allow setting arbitrary URLs for oauth2 proxy cookie refresh mechanism. #49 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation or CHANGELOG. - [ ] I have updated the documentation/CHANGELOG accordingly. - [ ] I have created a feature (non-master) branch for my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users with different tabs, applications etc will now have their cookie refreshed so when they open other tabs that have other applications, these applications will now be authenticated.
Example: I'm doing logging for 1 hour, when I open reporting, hsp reporting will ask for login due to expired cookie. Now this is no longer happer
https://www.hsdp.io/documentation/identity-and-access-management-iam/api-documents/resource-reference-api/oauth2-api#/Session%20Refresh/refreshSessionUsingGET
New settings introduced:
OAUTH2_PROXY_OIDC_ENABLE_COOKIE_REFRESHdefault falseOAUTH2_PROXY_OIDC_COOKIE_REFRESH_NAMEdefault 'hsdpamcookie'Motivation and Context
How Has This Been Tested?
Tested locally
Checklist: