[SEP] Subscription fix #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added scripts for easily building and serving
Improved the scripts and removed the bat versions
JuanvdHeijden
suggested changes
Jun 26, 2023
| for(Extension ext : extension) { | ||
| boolean deleted = false; | ||
|
|
||
| if(ext.getUrl().equals("createdBy")) { |
There was a problem hiding this comment.
Misuse of Extension in a Subscription Resource
Suggestion: Instead use a tag as part of the meta of a Resource
| } | ||
| } | ||
|
|
||
| if(deleted) { |
There was a problem hiding this comment.
Unnecessary if statement, move println to line 62
| * Queries all Subscriptions from the FHIR Store | ||
| * @return Array of all Subscriptions | ||
| */ | ||
| public Subscription[] getSubscriptions() { |
There was a problem hiding this comment.
Return List object instead of an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old subscriptions from the FHIR store, so there are no duplicates.