Skip to content

Commit

Permalink
chore: solve most vexing parse issue
Browse files Browse the repository at this point in the history
  • Loading branch information
daantimmer committed Jan 8, 2025
1 parent 2d600e4 commit 3fc4ae7
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions infra/stream/test/TestStreamWriterFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,23 +28,23 @@ class StreamWriterFileTest
TEST_F(StreamWriterFileTest, WriteString)
{
{
infra::StreamWriterFile streamWriter(file);
infra::StreamWriterFile streamWriter{ file };
streamWriter.Insert(infra::StdStringAsByteRange("Hello, world!"), noFailPolicy);
}

std::ifstream fileStream(file);
std::string content((std::istreambuf_iterator<char>(fileStream)), std::istreambuf_iterator<char>());
std::ifstream fileStream{ file };
std::string content{ std::istreambuf_iterator<char>(fileStream), std::istreambuf_iterator<char>() };
EXPECT_THAT(content, testing::StrEq("Hello, world!"));
}

TEST_F(StreamWriterFileTest, WriteDecimal)
{
{
infra::StreamWriterFile streamWriter(file);
infra::StreamWriterFile streamWriter{ file };
streamWriter.Insert(infra::MakeByteRange(std::uint64_t{ 0xCCCCCCCCCCCCCCCC }), noFailPolicy);
}

std::ifstream fileStream(file);
std::ifstream fileStream{ file };
std::uint64_t actual{ 0xFFFFFFFFFFFFFFFF };
fileStream.read(reinterpret_cast<char*>(&actual), sizeof(actual));
EXPECT_THAT(fileStream.fail(), testing::Eq(false));
Expand All @@ -54,16 +54,16 @@ TEST_F(StreamWriterFileTest, WriteDecimal)
TEST_F(StreamWriterFileTest, OverwriteExistingFile)
{
{
infra::StreamWriterFile streamWriter(file);
infra::StreamWriterFile streamWriter{ file };
streamWriter.Insert(infra::StdStringAsByteRange("Hello"), noFailPolicy);
}

{
infra::StreamWriterFile streamWriter(file);
infra::StreamWriterFile streamWriter{ file };
streamWriter.Insert(infra::StdStringAsByteRange("world!"), noFailPolicy);
}

std::ifstream fileStream(file);
std::string content(std::istreambuf_iterator<char>(fileStream), std::istreambuf_iterator<char>());
std::ifstream fileStream{ file };
std::string content{ std::istreambuf_iterator<char>(fileStream), std::istreambuf_iterator<char>() };
EXPECT_THAT(content, testing::StrEq("world!"));
}

0 comments on commit 3fc4ae7

Please sign in to comment.