feat: changed BoundedString::copy to copy up to length-pos charac…

…ters (#779)

* feat: changed BoundedVector::copy to copy up to `length-pos` characters

aligned with standard library behaviour

* chore: removed accidental include of ReallyAssert

infra/util/BoundedString.hpp

@@ -1081,7 +1081,8 @@ namespace infra
     template<class T>
     typename BoundedStringBase<T>::size_type BoundedStringBase<T>::copy(char* dest, size_type count, size_type pos)
     {
-        assert(pos + count <= length);
+        assert(pos <= length);
+        count = std::min(count, length - pos);
         std::copy(begin() + pos, begin() + pos + count, dest);
         return count;
     }

infra/util/test/TestBoundedString.cpp

@@ -587,6 +587,9 @@ TEST(BoundedStringTest, TestCopy)
     infra::BoundedString::WithStorage<5> string("abcde");
     EXPECT_EQ(3, string.copy(buffer, 3, 1));
     EXPECT_EQ('b', buffer[0]);
+
+    EXPECT_EQ(2, string.copy(buffer, 5, 3));
+    EXPECT_EQ('d', buffer[0]);
 }
 
 TEST(BoundedStringTest, TestResize)