Add setting for max image width when viewing .note files #24
Conversation
|
Hrm, I wonder how we would handle horizontal on this. My instinct is to make max-width a percentage at 5% increments or something instead. WDYT? Is there a reason you want pixel increment control? |
|
Note to self: I tested this branch and it works fine as described. Code looks fine. Just needs a squash after the percentage discussion above. |
|
I think you're right, a percentage will probably be more intuitive for horizontal notes, as well as future larger notes from the A5X2 device. Pixels just happened to be convenient for implementation. I am going out of town for a week but will come back to this when I return! |
|
I actually prototyped it and CSS supports a percentage and it is a percentage of the enclosing div. So it works as you might hope. Just a couple of lines to edit. Safe travels! Sent from a pocket terminal On May 25, 2024, at 6:29 PM, James Li ***@***.***> wrote:
I think you're right, a percentage will probably be more intuitive for horizontal notes, as well as future larger notes from the A5X2 device. Pixels just happened to be convenient for implementation. I am going out of town for a week but will come back to this when I return!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Per issue philips#22, adds a max px width setting in the settings pane. Notes are still responsive to window size below the max width.
I think this makes the setting behavior more intuitive, because the slider value now always means what it seems to mean. Previously, setting to 0px allowed the page to go to its full 1404px width, but that's basically the same as just setting 1400px for the max width. I set the lower bound at 100px so that a user can't accidentally make the pages disappear entirely. Note: I know pages in landscape orientation would have a width of 1872px, but I'm going with 1400px for now because: - This plugin doesn't seem to be parsing landscape notes correctly at the moment - 1400px is already very wide
I removed the special 0px behavior in the previous commit but forgot to update this text in the settings description.
james-xli
force-pushed
the
feature/note-max-width
branch
from
281d688 to
47084d5
Compare
…atch current version in main
… instead of just width. Multiple pages can be visible horizontally. I think this should play nice with horizontal pages, but am unable to test because horizontal pages aren't working quite yet. Also changed the default setting to 800px, which is a nice medium size to be legible but not too big. Max setting now goes to 1900 px (slightly larger than the 1872 px long edge of a Nomad page).
|
I tried the percentage but couldn't find a clean way to implement my desired behavior. Doing something like (Maybe I'm totally misunderstanding what you were describing above, or overlooking something obvious? Please let me know if so!) Instead, to handle horizontal pages nicely (i.e., keep them at the same apparent scale as vertical pages), I changed the setting so it limits both the height and width of the image. It's now called "Max image side length" in the Settings pane. For example, the new default limit of 800 px would allow a vertical page up to 800 px tall, or a horizontal page up to 800 px wide. Unfortunately I couldn't actually test this on any actual horizontal pages since the library doesn't support those yet, but I'm hopeful that this will play nice when that time comes! I implemented this by creating a new parent div with the Some screenshots to show what I mean:
Please let me know what you think, thanks! Cheers :) |
|
One more screenshot to demonstrate the added functionality: if I keep the window the same size as in the last screenshot above, but set the image side length limit to something smaller (here 400 px), now I can see a whole bunch of pages at once:
|
|
This looks great for being able to see pages side by side, can we merge this @philips |
|
Sorry for the long delay. I have made a beta release with this feature so I can test it for a bit on my own devices. You can install it with BRAT - it is 2.3.0 |
|
Thanks @philips! Glad to see you back here. |
|
First bug: At 200px on my iPhone the text contents have no padding so when two pages are adjacent the words run into each other. |
|
Filed issue #38 |
Per issue #22, I took a stab at adding a max px width setting in the settings pane:
Set to 500 px as shown above, my test note looks like this:
Notes are still responsive to window size below the max width.
The default value is 1400px, which is nearly the max width of a note (both A5X and A6X2) in portrait orientation. This is the same as the preexisting behavior. That same test note looks like this at the max 1400px width:
I am pretty new to contributing on Github so I would like any and all feedback, thanks!