estimator.ebai with wide eclipse fix attempt 2 (2.3.18 release) (#405)

* actually fixes bug (see 2.3.13) that raised internal error when running ebai on an eclipse with width larger than 0.25 in phase.  Note that these systems will still return nans as ebai is not well-suited to these systems, but the internal error will no longer occur.

README.md

@@ -84,6 +84,10 @@ To understand how to use PHOEBE, please consult the [tutorials, scripts and manu
 CHANGELOG
 ----------
 
+### 2.3.18 - estimator.ebai with wide eclipse fix (attempt 2)
+
+* actually fixes bug (see 2.3.13) that raised internal error when running ebai on an eclipse with width larger than 0.25 in phase.  Note that these systems will still return nans as ebai is not well-suited to these systems, but the internal error will no longer occur.
+
 ### 2.3.17 - optimizer MPI fix
 
 * enables parallelization (per-time or per-dataset) for optimizers.
@@ -102,7 +106,7 @@ CHANGELOG
 
 ### 2.3.13 - estimator.ebai with wide eclipse fix
 
-* fix bug that raised internal error when running ebai on an eclipse with width larger than 0.25 in phase.  Note that these systems will still return nans as ebai is not well-suited to these systems, but the internal error will no longer occur.
+* fix bug (but not really - see 2.3.18) that raised internal error when running ebai on an eclipse with width larger than 0.25 in phase.  Note that these systems will still return nans as ebai is not well-suited to these systems, but the internal error will no longer occur.  
 
 ### 2.3.12 - plot univariate distributions latex label fix
 

phoebe/__init__.py

@@ -16,7 +16,7 @@
 
 """
 
-__version__ = '2.3.17'
+__version__ = '2.3.18'
 
 import os as _os
 import sys as _sys

phoebe/solverbackends/solverbackends.py

@@ -1039,12 +1039,15 @@ def run_worker(self, b, solver, compute=None, **kwargs):
         lc_geom_dict = lc_geometry.estimate_eclipse_positions_widths(phases, fluxes)
         if np.max(lc_geom_dict.get('ecl_widths', [])) > 0.25:
             logger.warning("ebai: eclipse width over 0.25 detected.  Returning all nans")
+            pshift = 0.0
             t0_supconj = np.nan
             teffratio = np.nan
             requivsumfrac = np.nan
             esinw = np.nan
             ecosw = np.nan
             sini = np.nan
+            ebai_phases = []
+            ebai_fluxes = []
         else:
             ecl_positions = lc_geom_dict.get('ecl_positions')
             # assume primary is close to zero?

setup.py

@@ -346,8 +346,8 @@ def _env_variable_bool(key, default):
     long_description = "\n".join(long_description_s[long_description_s.index("INTRODUCTION"):])
 
 setup (name = 'phoebe',
-       version = '2.3.17',
-       description = 'PHOEBE 2.3.17',
+       version = '2.3.18',
+       description = 'PHOEBE 2.3.18',
        long_description=long_description,
        author = 'PHOEBE development team',
        author_email = '[email protected]',
@@ -367,7 +367,7 @@ def _env_variable_bool(key, default):
             'Programming Language :: Python :: 3 :: Only',
         ],
        python_requires='>=3.6, <4',
-       download_url = 'https://github.com/phoebe-project/phoebe2/tarball/2.3.17',
+       download_url = 'https://github.com/phoebe-project/phoebe2/tarball/2.3.18',
        packages = ['phoebe', 'phoebe.parameters', 'phoebe.parameters.solver', 'phoebe.parameters.figure', 'phoebe.frontend', 'phoebe.constraints', 'phoebe.dynamics', 'phoebe.distortions', 'phoebe.algorithms', 'phoebe.atmospheres', 'phoebe.backend', 'phoebe.solverbackends', 'phoebe.solverbackends.ebai', 'phoebe.utils', 'phoebe.helpers', 'phoebe.pool', 'phoebe.dependencies', 'phoebe.dependencies.autofig', 'phoebe.dependencies.nparray', 'phoebe.dependencies.distl', 'phoebe.dependencies.unitsiau2015'],
        install_requires=['numpy>=1.12','scipy>=1.2','astropy>=1.0', 'corner', 'pytest', 'requests', 'python-socketio[client]']+['flask', 'flask-cors', 'flask-socketio', 'gevent-websocket'],
        package_data={'phoebe.atmospheres':['tables/wd/*', 'tables/passbands/*'],