exposure time support for jktebop backend #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. To calculate RV semi-amplitude (K), system semi-major-axis was used previously instead of component sma (sma vs. center of mass). Before, any change in the mass ratio had no effect on the modelled rvs. 2. Small left-over discrepancy corrected, as RV amplitude K did not take eccentricity into account. Now includes term 1/(sqrt(1-ecc^2)).
This reverts commit cd3b7e5.
…ameters fti_method, fti_oversample, and exptime. The implementation uses twigs since b.get_value() would fail in odd ways: - Either fails because returns a parameter set with both PHOEBE and JKTEBOP parameters - Or fails because jktebop parameters are not found if "compute" or "kind" is specified For some reason, when compute is instead specified using twigs, it works without any issue. Uses a try except statement to check if fti_oversample and exptime exists, instead of an if statement. Should probably be improved. Checked that in this implementation, fti_oversample accurately does not exist for RV curves, meaning it is done on a dataset-by-dataset basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for exposure times via fti_oversample in the jktebop alternate backend.
TODO:
compute.pyso that all backends that support exposure time can pull in those parameters)Closes #700