Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phoebe-server updates #959

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 14, 2024

This PR updates phoebe-server to be functional on modern browser and removes deprecation warnings. This and phoebe-project/phoebe2-ui#28 will hopefully get the UI in a working state again.

There still is a remaining issue on main regarding log10 in constraints that seems to be blocking this from working, so will try to fix that before testing this fully.

Closes https://github.com/phoebe-project/phoebe-development/issues/121

@kecnry kecnry marked this pull request as ready for review October 23, 2024 17:24
@kecnry kecnry requested a review from aprsa October 23, 2024 17:24
Copy link
Contributor

@aprsa aprsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kecnry kecnry merged commit 28a7d61 into phoebe-project:bugfix-2.4.16 Oct 25, 2024
20 checks passed
@kecnry kecnry deleted the server-updates branch October 25, 2024 18:11
@kecnry kecnry mentioned this pull request Oct 25, 2024
kecnry added a commit that referenced this pull request Oct 25, 2024
* Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe. [#965]
* Updates to phoebe-server to be compatible with modern browser requirements. [#959]
* Fix support for python 3.13, remove official support for python 3.7. [#968]

---------

Co-authored-by: Martin Horvat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants