-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment check #965
Fix alignment check #965
Conversation
Awesome! 🤞 Looks like this was branched off of |
Yes, it seems that I did this. I can create another branch from bugfix, if you need this. I just cherry pick the last two commits. |
no worries - I'll take care of it! EDIT: ended up just rebasing the bugfix branch to be on top of a few CI changes made directly to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the example from the issue no longer raises an error on my machine and the diff looks reasonable to me. Thanks! 😄
@horvatm - is "Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe" a good changelog entry for this? Or do you have suggested language to explain this better? |
a9d25a1
to
fa74a8f
Compare
Yes, I think this is an accurate title for the fix. |
* Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe. [#965] * Updates to phoebe-server to be compatible with modern browser requirements. [#959] * Fix support for python 3.13, remove official support for python 3.7. [#968] --------- Co-authored-by: Martin Horvat <[email protected]>
I think I corrected the problem connected to issue #773 .
Closes #773