Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment check #965

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

horvatm
Copy link
Member

@horvatm horvatm commented Oct 18, 2024

I think I corrected the problem connected to issue #773 .

Closes #773

@kecnry
Copy link
Member

kecnry commented Oct 18, 2024

Awesome! 🤞 Looks like this was branched off of master but then targets bugfix-2.4.16 - want me to move the commits and force push to your branch?

@kecnry kecnry linked an issue Oct 18, 2024 that may be closed by this pull request
@kecnry kecnry requested review from kecnry and aprsa October 18, 2024 19:17
@horvatm
Copy link
Member Author

horvatm commented Oct 18, 2024

Yes, it seems that I did this. I can create another branch from bugfix, if you need this. I just cherry pick the last two commits.

@kecnry
Copy link
Member

kecnry commented Oct 18, 2024

no worries - I'll take care of it!

EDIT: ended up just rebasing the bugfix branch to be on top of a few CI changes made directly to master to avoid this in the future.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the example from the issue no longer raises an error on my machine and the diff looks reasonable to me. Thanks! 😄

@kecnry
Copy link
Member

kecnry commented Oct 23, 2024

@horvatm - is "Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe" a good changelog entry for this? Or do you have suggested language to explain this better?

@kecnry kecnry force-pushed the fix_alignment_check branch from a9d25a1 to fa74a8f Compare October 23, 2024 12:46
@horvatm
Copy link
Member Author

horvatm commented Oct 23, 2024

@horvatm - is "Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe" a good changelog entry for this? Or do you have suggested language to explain this better?

Yes, I think this is an accurate title for the fix.

@kecnry kecnry merged commit 2369cc7 into phoebe-project:bugfix-2.4.16 Oct 23, 2024
18 of 19 checks passed
@kecnry kecnry mentioned this pull request Oct 23, 2024
kecnry added a commit that referenced this pull request Oct 25, 2024
* Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe. [#965]
* Updates to phoebe-server to be compatible with modern browser requirements. [#959]
* Fix support for python 3.13, remove official support for python 3.7. [#968]

---------

Co-authored-by: Martin Horvat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

near-critical system fails Omega_at_vol
3 participants