Fix for creating a stream context from a custom user parameters #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix for dynamic using of
ssl_context => verify_peer
option.In my case it was Local\AWS environment and there was no option to use one yml config for both environments.
How to reproduce:
On using custom class for an option
connection_parameters_provider: App\Service\ConnectionParametersProviderService
I'm deciding to use or not SSL
But
RabbitMq/AMQPConnectionFactory.php
tries to create stream context for SSL options before it gets it from custom Connection parameters from users class, and there is no stream context for it.In total, parameters looks like (invalid):
instead of (valid):
The fix:
Change the order of getting an
user parameters
and creating astream context