Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Producer events #728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nathanjrobertson
Copy link
Contributor

@nathanjrobertson nathanjrobertson commented Oct 16, 2024

Currently, Consumers have events which allow users of the bundle to add custom code. This PR adds this support to Producers as well. Really useful for project specific logging, message format validation, etc.

The only real difference between the Consumer and Producer events is the addition of the routingKey field in the Events, as $producer->routingKey is only set in the case where it is explicitly set, and not in the case where defaultRoutingKey is used. This PR currently works around this by providing that extra field, but it might be better to change Producer.php (line 67) from:

$real_routingKey = $routingKey !== null ? $routingKey : $this->defaultRoutingKey;

to

if ($routingKey === null) {
    $routingKey = $this->defaultRoutingKey;
}

and then removing the extra routingKey field from the Events. Happy to take feedback on which way you'd prefer this one go.

My use case for this support is message validation prior to publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant