Improvement handle disconnects and reconnect when appropriate #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disconnects-and-reconnect-when-appropriate
stickler-ci
reviewed
May 22, 2017
src/AsyncClient.php
Outdated
| $event = Event::createFromMessage($message); | ||
|
|
||
| if ($event->getEvent() === 'pusher:error') { | ||
| return Observable::fromPromise(reject(new PusherErrorException($event->getData()['message'], $event->getData()['code']))); |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 142 characters
stickler-ci
reviewed
May 22, 2017
src/AsyncClient.php
Outdated
| */ | ||
| private function handleLowLevelError(Throwable $throwable) | ||
| { | ||
| if (!($throwable instanceof WebsocketErrorException) && !($throwable instanceof RuntimeException) && !($throwable instanceof PusherErrorException)) { |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 157 characters
stickler-ci
reviewed
May 22, 2017
tests/AsyncClientTest.php
Outdated
| $observable = Observable::error($error, new ImmediateScheduler()); | ||
| $client = new AsyncClient($observable); | ||
| $client->channel('test')->subscribe( | ||
| function () {}, |
There was a problem hiding this comment.
Closing brace must be on a line by itself
stickler-ci
reviewed
May 22, 2017
tests/AsyncClientTest.php
Outdated
| $resolver->resolve('ws.pusherapp.com')->shouldBeCalled()->willReturn(reject($error)); | ||
| $client = AsyncClient::create($loop, 'abc', $resolver->reveal()); | ||
| $client->channel('test')->subscribe(); | ||
| $loop->addTimer(1, function () {}); |
There was a problem hiding this comment.
Closing brace must be on a line by itself
stickler-ci
reviewed
May 22, 2017
src/AsyncClient.php
Outdated
| */ | ||
| private function handleLowLevelError(Throwable $throwable) | ||
| { | ||
| if ( |
There was a problem hiding this comment.
Expected 0 spaces after opening bracket; newline found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Requires RxPHP/RxWebsocket#9 / RxPHP/RxWebsocket#10