Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci deprecations #58

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

Chris53897
Copy link

No description provided.

@dbu
Copy link
Contributor

dbu commented Mar 3, 2024

thanks for this upgrade.

seems we have not looked at this since the projects switched to semantic branch naming. but your change is still valid, will merge it. and then will update the ci files.

@dbu dbu merged commit 42ca4c5 into php-http:master Mar 3, 2024
1 of 9 checks passed
@Chris53897 Chris53897 deleted the feature/improve-ci branch March 3, 2024 09:26
@Chris53897
Copy link
Author

thanks. I just want to keep a quick try if i can migrate it to PHPUnit 10/11.
But it seems there is some work todo, to make ci pass.

@dbu
Copy link
Contributor

dbu commented Mar 3, 2024

yeah we first need to fix the builds. it seems mostly code rot, i solved the curl-client issues and started working on socket-client issues in php-http/socket-client#72

if you have time to look into the buzz or guzzle5/6 failures that would be awesome :-)

@Chris53897
Copy link
Author

I will try to help, but there are failing tests, errors and deprecations no matter which repo i open ;)
I opended a PR th3n3rd/cartesian-product#9 (otherwise this functionality could be replaced).
I will send some PR with easy picks, and try to solve some more.
Can try a quick peek into your proposed repo. But no gurantees.

@Chris53897
Copy link
Author

As this repos are readonly and archived. What todo?

@dbu
Copy link
Contributor

dbu commented Mar 6, 2024

the other maintainers on php-http have mostly moved to other things. and i also don't have very much time to invest. there is indeed quite some code rot.

i realized we archived guzzle5 and 6 adapter, so i removed them from the test. and buzz mostly succeeds now, there are just a few failures that seem to be on buzz side and not with the test setup, so i just merged #59, don't think we should invest more energy into it.

@dbu
Copy link
Contributor

dbu commented Mar 6, 2024

and thanks for the help - i appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants