-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make package compatible with stream interface Compatibility stream interface v2 #75
Make package compatible with stream interface Compatibility stream interface v2 #75
Conversation
TO BE REVERTED after [1] AND need to update min version for the tests package [1] php-http/client-integration-tests#60
… current implementation to avoid having failed tests
There is implementation for interface from this package
/cc @dbu |
$ vendor/bin/phpunit
PHPUnit 9.6.20 by Sebastian Bergmann and contributors.
SSSSS............................................................ 65 / 89 ( 73%)
........................ 89 / 89 (100%)
Time: 00:21.389, Memory: 10.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 89, Assertions: 901, Skipped: 5. |
thanks a lot! ok to make this 2.3 instead of 3.0? and can you see if you can fix the phpstan complaint? looks like we miss some sanity check (or have incorrect annotations somewhere) |
I'm Ok with documenting minor BC break for extenders of the |
…ring in case of `0` length
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
i will adjust the changelog and add the @internal
after merging.
\Http\Client\Socket\Stream
class)What's in this PR?
Replaces #72
Fixes compatibility with
psr/http-message
v2Why?
For now, the current package contains implementation for the
\Psr\Http\Message\StreamInterface
, but there's no mention of supported versions ofpsr/http-message
in composer.json.After some upgrades of
php-http/httpplug
- they declared compatibility withpsr/http-message
v2 and the current package was broken if the project installed it withpsr/http-message
v2 (see mentioned issue)Checklist