Skip to content

Commit

Permalink
Getters added (#58) (#59)
Browse files Browse the repository at this point in the history
  • Loading branch information
jormaechea authored and amouhzi committed Dec 4, 2018
1 parent c12b2c4 commit d22086d
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions src/Curl/Curl.php
Original file line number Diff line number Diff line change
Expand Up @@ -696,4 +696,24 @@ public function getResponseHeaders($headerKey = null)

return $headers;
}

public function getResponse()
{
return $this->response;
}

public function getErrorCode()
{
return $this->curl_error_code;
}

public function getErrorMessage()
{
return $this->curl_error_message;
}

public function getHttpStatus()
{
return $this->http_status_code;
}
}

3 comments on commit d22086d

@nadar
Copy link
Member

@nadar nadar commented on d22086d Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amouhzi @jormaechea this is missing any php docs and is there for not recommend in such a highly used library ;-) Even a since tag i missing

@amouhzi
Copy link
Member

@amouhzi amouhzi commented on d22086d Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadar I agree with you. But the goal is to encourage people to contribute without too much stress.

@nadar
Copy link
Member

@nadar nadar commented on d22086d Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree on this, but trough pull request comments, approvals and guidance you even help the contributors to take an eye on such details - which are important in software development process. With latest GitHub changes you could even write directly in the PR branch in order to add this informations if contributors can't.

Please sign in to comment.