-
Notifications
You must be signed in to change notification settings - Fork 120
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c12b2c4
commit d22086d
Showing
1 changed file
with
20 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d22086d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amouhzi @jormaechea this is missing any php docs and is there for not recommend in such a highly used library ;-) Even a since tag i missing
d22086d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadar I agree with you. But the goal is to encourage people to contribute without too much stress.
d22086d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree on this, but trough pull request comments, approvals and guidance you even help the contributors to take an eye on such details - which are important in software development process. With latest GitHub changes you could even write directly in the PR branch in order to add this informations if contributors can't.