Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI actions/upload-artifact version #281

Closed
wants to merge 2 commits into from
Closed

Bump CI actions/upload-artifact version #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba8fea
Bump actions/upload-artifact version
neildaniels Jan 30, 2025
e9337b7
PHPStan fixes
neildaniels Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
run: "vendor/bin/phpunit --coverage-clover=coverage.xml"

- name: "Upload coverage file"
uses: "actions/upload-artifact@v2"
uses: "actions/upload-artifact@v4"
with:
name: "phpunit-${{ matrix.php-version }}-${{ matrix.deps }}-${{ hashFiles('composer.lock') }}.coverage"
path: "coverage.xml"
Expand Down
2 changes: 1 addition & 1 deletion lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
class SessionTokenRequestListener
{
/**
* @var string|SessionBearerToken|GuestSessionToken
* @var SessionBearerToken|GuestSessionToken
*/
private $token;

Expand All @@ -38,7 +38,7 @@
*/
public function __construct(SessionToken $token)
{
$this->token = $token;

Check failure on line 41 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1) 

Property Tmdb\Event\Listener\Request\SessionTokenRequestListener::$token (Tmdb\Token\Session\GuestSessionToken|Tmdb\Token\Session\SessionBearerToken) does not accept Tmdb\Token\Session\SessionToken.

Check failure on line 41 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.0) 

Property Tmdb\Event\Listener\Request\SessionTokenRequestListener::$token (Tmdb\Token\Session\GuestSessionToken|Tmdb\Token\Session\SessionBearerToken) does not accept Tmdb\Token\Session\SessionToken.

Check failure on line 41 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4) 

Property Tmdb\Event\Listener\Request\SessionTokenRequestListener::$token (Tmdb\Token\Session\GuestSessionToken|Tmdb\Token\Session\SessionBearerToken) does not accept Tmdb\Token\Session\SessionToken.

Check failure on line 41 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4) 

Property Tmdb\Event\Listener\Request\SessionTokenRequestListener::$token (Tmdb\Token\Session\GuestSessionToken|Tmdb\Token\Session\SessionBearerToken) does not accept Tmdb\Token\Session\SessionToken.

Check failure on line 41 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1) 

Property Tmdb\Event\Listener\Request\SessionTokenRequestListener::$token (Tmdb\Token\Session\GuestSessionToken|Tmdb\Token\Session\SessionBearerToken) does not accept Tmdb\Token\Session\SessionToken.

Check failure on line 41 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.0) 

Property Tmdb\Event\Listener\Request\SessionTokenRequestListener::$token (Tmdb\Token\Session\GuestSessionToken|Tmdb\Token\Session\SessionBearerToken) does not accept Tmdb\Token\Session\SessionToken.
$this->requestQueryHelper = new RequestQueryHelper();
}

Expand All @@ -55,7 +55,7 @@
);

return;
} elseif ($this->token instanceof GuestSessionToken) {

Check failure on line 58 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1) 

Instanceof between Tmdb\Token\Session\GuestSessionToken and Tmdb\Token\Session\GuestSessionToken will always evaluate to true.

Check failure on line 58 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.0) 

Instanceof between Tmdb\Token\Session\GuestSessionToken and Tmdb\Token\Session\GuestSessionToken will always evaluate to true.

Check failure on line 58 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4) 

Instanceof between Tmdb\Token\Session\GuestSessionToken and Tmdb\Token\Session\GuestSessionToken will always evaluate to true.

Check failure on line 58 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4) 

Instanceof between Tmdb\Token\Session\GuestSessionToken and Tmdb\Token\Session\GuestSessionToken will always evaluate to true.

Check failure on line 58 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.1) 

Instanceof between Tmdb\Token\Session\GuestSessionToken and Tmdb\Token\Session\GuestSessionToken will always evaluate to true.

Check failure on line 58 in lib/Tmdb/Event/Listener/Request/SessionTokenRequestListener.php

View workflow job for this annotation

GitHub Actions / PHPStan (8.0) 

Instanceof between Tmdb\Token\Session\GuestSessionToken and Tmdb\Token\Session\GuestSessionToken will always evaluate to true.
$key = 'guest_session_id';
} else {
$key = 'session_id';
Expand Down
8 changes: 0 additions & 8 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@ parameters:
count: 1
path: lib/Tmdb/Model/Movie.php

-
message: """
#^Call to deprecated method getReleases\\(\\) of class Tmdb\\\\Model\\\\Movie\\:
Use the getReleaseDates instead$#
"""
count: 1
path: lib/Tmdb/Repository/MovieRepository.php

-
message: """
#^Return type of method Tmdb\\\\Repository\\\\MovieRepository\\:\\:getReleases\\(\\) has typehint with deprecated class Tmdb\\\\Model\\\\Movie\\\\Release\\:
Expand Down
Loading