You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tedbow our ActiveDirIsWritable and StagingDirIsWritable preconditions currently only test that the top level directories themselves are writable. Non-writable children and descendants therefore would not be caught until they actually cause failures during file syncing, potentially corrupting the codebase. I think we should make the checks recursive, even though that will make them slower. What do you think?
I think that, from a usefulness standpoint, performance is less important than correctness. Being able to detect problems before they happen is more valuable.
The one caveat I can think of here is that, in some cases, there are some directories that won't be writable, and shouldn't be writable, and will also be ignored by the staging operations. It would be good to be able to specify which paths should simply be ignored during permission checks.
TravisCarden
changed the title
Should "directory is writable" preconditions be recursive?
Make "directory is writable" preconditions recursive
Feb 23, 2023
@tedbow our
ActiveDirIsWritable
andStagingDirIsWritable
preconditions currently only test that the top level directories themselves are writable. Non-writable children and descendants therefore would not be caught until they actually cause failures during file syncing, potentially corrupting the codebase. I think we should make the checks recursive, even though that will make them slower. What do you think?cc @phenaproxima @wimleers
The text was updated successfully, but these errors were encountered: