Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "directory is writable" preconditions recursive #67

Open
TravisCarden opened this issue Feb 15, 2023 · 1 comment
Open

Make "directory is writable" preconditions recursive #67

TravisCarden opened this issue Feb 15, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@TravisCarden
Copy link
Collaborator

@tedbow our ActiveDirIsWritable and StagingDirIsWritable preconditions currently only test that the top level directories themselves are writable. Non-writable children and descendants therefore would not be caught until they actually cause failures during file syncing, potentially corrupting the codebase. I think we should make the checks recursive, even though that will make them slower. What do you think?

cc @phenaproxima @wimleers

@phenaproxima
Copy link
Contributor

Personally, I'm +1 for this.

I think that, from a usefulness standpoint, performance is less important than correctness. Being able to detect problems before they happen is more valuable.

The one caveat I can think of here is that, in some cases, there are some directories that won't be writable, and shouldn't be writable, and will also be ignored by the staging operations. It would be good to be able to specify which paths should simply be ignored during permission checks.

@TravisCarden TravisCarden added this to the v2.0.0 milestone Feb 23, 2023
@TravisCarden TravisCarden changed the title Should "directory is writable" preconditions be recursive? Make "directory is writable" preconditions recursive Feb 23, 2023
@TravisCarden TravisCarden added the enhancement New feature or request label Feb 23, 2023
@TravisCarden TravisCarden modified the milestones: v2.0.0, v2.1.0 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants