Generalize AbstractLinkIteratingPrecondition as AbstractFileIteratingPrecondition #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recondition as AbstractFileIteratingPrecondition.
TravisCarden
commented
Mar 8, 2023
src/Infrastructure/Service/Precondition/AbstractFileIteratingPrecondition.php
Show resolved
Hide resolved
TravisCarden
commented
Mar 8, 2023
src/Infrastructure/Service/Precondition/AbstractFileIteratingPrecondition.php
Show resolved
Hide resolved
TravisCarden
commented
Mar 8, 2023
src/Infrastructure/Service/Precondition/AbstractFileIteratingPrecondition.php
Show resolved
Hide resolved
|
Taking over this review at @wimleers's request. |
phenaproxima
approved these changes
Mar 9, 2023
src/Domain/Service/Precondition/NoAbsoluteSymlinksExistInterface.php
Outdated
Show resolved
Hide resolved
src/Domain/Service/Precondition/NoSymlinksPointOutsideTheCodebaseInterface.php
Outdated
Show resolved
Hide resolved
src/Infrastructure/Service/Precondition/AbstractFileIteratingPrecondition.php
Show resolved
Hide resolved
src/Infrastructure/Service/Precondition/AbstractFileIteratingPrecondition.php
Show resolved
Hide resolved
src/Infrastructure/Service/Precondition/AbstractFileIteratingPrecondition.php
Show resolved
Hide resolved
TravisCarden
force-pushed
the
feature/generalize-abstract-file-iterating-precondition
branch
from
e5650b8 to
3283494
Compare
|
Thanks, @phenaproxima. Merging. 🙂 |
TravisCarden
deleted the
feature/generalize-abstract-file-iterating-precondition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emphasis on Link iterating to File iterating. This refactoring improves the semantics of link-related preconditions, effectively answering @wimleers feedback in #100, I believe, and preparing the way for future enhancements like #67, which will also need to iterate over all files, not just links.