Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for ini_parse_quantity function #1810

Merged
merged 5 commits into from
Dec 5, 2022
Merged

add docs for ini_parse_quantity function #1810

merged 5 commits into from
Dec 5, 2022

Conversation

realFlowControl
Copy link
Contributor

Hello there 🖖

this will add the documentation for the ini_parse_quantity function as found in #1803

Kind regards
Florian

@saundefined saundefined mentioned this pull request Sep 8, 2022
Closed
@saundefined saundefined added this to the PHP 8.2 milestone Sep 8, 2022
@Girgias
Copy link
Member

Girgias commented Sep 30, 2022

Just landed 0f8b9eb49bd644f07175e9191d2cc146737446ad to add support for 0b and 0o prefixes, wondering if it makes sense to add examples with prefixes in the docs? (hex has worked since forever)

@cmb69
Copy link
Member

cmb69 commented Sep 30, 2022

wondering if it makes sense to add examples with prefixes in the docs?

I think it would make more sense, to add some ini_get() examples.

@devnexen
Copy link
Member

devnexen commented Nov 3, 2022

Looks good but cc @cmb69

@realFlowControl realFlowControl force-pushed the docs/ini_parse_quantity branch 2 times, most recently from 9732423 to d2a0a0f Compare November 3, 2022 20:25
@realFlowControl
Copy link
Contributor Author

Hey there,
sorry for taking so long to come back to this PR. I think I incorporated all your hints 😄
Hope everything is fine, if there is something else, just ping.
@Girgias, @cmb69: I added the prefixes to the docs, I think it should be there for completeness.

Girgias
Girgias requested changes Nov 4, 2022
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure for the wording of the error section, but warnings should ideally not be mentioned in the return value section (yes the manual is not super consistent on this)

reference/info/functions/ini-parse-quantity.xml Outdated Show resolved Hide resolved
reference/info/functions/ini-parse-quantity.xml Outdated Show resolved Hide resolved
@mumumu
Copy link
Member

mumumu commented Dec 5, 2022

@Girgias ping for review.

cmb69
cmb69 reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the missing link, this looks good to me.

reference/info/functions/ini-parse-quantity.xml Outdated Show resolved Hide resolved
cmb69
cmb69 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit 87955a6 into php:master Dec 5, 2022
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@realFlowControl @Girgias
@cmb69 @claudepache
Add docs for ini_parse_quantity function (php#1810)
408a06c 
Co-authored-by: Florian Engelhardt <[email protected]>
Co-authored-by: George Peter Banyard <[email protected]>
Co-authored-by: Christoph M. Becker <[email protected]>
@realFlowControl realFlowControl deleted the docs/ini_parse_quantity branch July 31, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen left review comments

@Girgias Girgias Girgias approved these changes

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.2
Development

Successfully merging this pull request may close these issues.
7 participants
@realFlowControl @Girgias @cmb69 @devnexen @mumumu @afilina @saundefined