Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reference from installation.problems to faq.installation #3785

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Sep 24, 2024

A chapter with three tiny sections is annoying.

@cmb69
Copy link
Member

cmb69 commented Sep 24, 2024

Makes sense to collapse this, but I'm not sure whether we should keep the info about the install mailing list. Apparently, nobody is responding there for a couple of years: https://news-web.php.net/php.install.

@jimwins
Copy link
Member Author

jimwins commented Sep 24, 2024

Maybe it would be better to just remove this section entirely and link directly to faq.installation instead.

@Girgias
Copy link
Member

Girgias commented Sep 25, 2024

If the section is removed, remember to first delete all the notes on these pages.

@Girgias
Copy link
Member

Girgias commented Sep 27, 2024

I do think removing this and linking to the FAQ is better, as this section seems kinda pointless?

Not sure what I think about the "if you found a bug" thing, as it makes some sense to have this somewhere, but not in the installation section.

@jimwins jimwins changed the title Flatten the Problems 'chapter' into a single section, depersonalize Remove installation.problems, point to faq.installation instead Sep 27, 2024
@jimwins
Copy link
Member Author

jimwins commented Sep 27, 2024

Okay, removal it is. The stuff about bug reporting is already in the general FAQ. Requires a doc-base change because the section is in manual.xml.in.

@Girgias
Copy link
Member

Girgias commented Sep 29, 2024

Could you split it in two commits? First change where the link points, merge this, update translations, then remove the page and update doc-base, seems like a more reliable course of action

@jimwins
Copy link
Member Author

jimwins commented Sep 30, 2024

Sorry for the flapping, fixed this PR to just update the reference. Will submit another PR to remove.

@jimwins jimwins changed the title Remove installation.problems, point to faq.installation instead Change reference from installation.problems to faq.installation Sep 30, 2024
@Girgias Girgias merged commit f033d4b into php:master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants