[ci skip] Clarify intention in phpdbg, removing one TODO comment #16014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The point of WATCH_ON_BUCKET is to watch for all 3 fields of the bucket, so the fallthrough is intended.
Girgias
approved these changes
Sep 23, 2024
Girgias
reviewed
Sep 24, 2024
| @@ -138,10 +138,10 @@ const phpdbg_command_t phpdbg_watch_commands[] = { | |||
| bool phpdbg_check_watch_diff(phpdbg_watchtype type, void *oldPtr, void *newPtr) { | |||
| switch (type) { | |||
| case WATCH_ON_BUCKET: | |||
| if (memcmp(&((Bucket *) oldPtr)->h, &((Bucket *) newPtr)->h, sizeof(Bucket) - sizeof(zval) /* key/val comparison */) != 0) { | |||
| if (memcmp(&((Bucket *) oldPtr)->h, &((Bucket *) newPtr)->h, sizeof(Bucket) - sizeof(zval) /* hash+key comparison */) != 0) { | |||
| return 2; | |||
There was a problem hiding this comment.
Unrelated thing I just noticed, but the function says it returns bool but here it returns 2.
I am going to blame myself for not catching this when I probably changed the return type, but is the value of 2 important here?
There was a problem hiding this comment.
See https://heap.space/search?project=PHP-7.0&project=PHP-7.1&full=&defs=&refs=phpdbg_check_watch_diff&path=&hist=&type= (seems to have been irrelevant from the beginning).
There was a problem hiding this comment.
Yeah indeed it seems irrelevant, maybe it was intended at one point to be used to signal the bucket key has changed, but who knows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of WATCH_ON_BUCKET is to watch for all 3 fields of the bucket, so the fallthrough is intended.