Run stream_server_reneg_limit.phpt on Windows, too #17193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might work now on Windows, but need to wait for #17180. |
As is, the client code may block on Windows when trying to read STDERR; if that happens, neither the openssl nor the php processes would be terminated, causing further issues for the test suite. We fix this by using `stream_select()` and only read if there is data available. This may cause some delay until we hit the timeout, but it might be necessary to "empty" STDERR.
cmb69
force-pushed
the
cmb/stream_server_reneg_limit.phpt
branch
from
caf3913 to
f8a9b81
Compare
Nope, the issues are not caused by port collisions. I have no idea what's the cause, though. Might not make much sense to spend further time on this, given that renegotiation is a thing of the past (not supported by TLS 1.3), so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, the client code may block on Windows when trying to read STDERR; if that happens, neither the openssl nor the php processes would be terminated, causing further issues for the test suite.
We fix this by using
stream_select()and only read if there is data available. This may cause some delay until we hit the timeout, but it might be necessary to "empty" STDERR.Tackling #16086 piecemeal might be a better idea.