ext/sockets: linux AF_PACKET support. #17440
Closed
+215
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
socket_ether_linux
branch
6 times, most recently
from
1c7ea4d to
cb717cc
Compare
arnaud-lb
reviewed
Jan 20, 2025
ext/sockets/sockets.stub.php
Outdated
Comment on lines
2049
to
2055
| function socket_getsockname(Socket $socket, &$address, ?int &$objint = null): bool {} | ||
|
|
||
| /** | ||
| * @param string $address | ||
| * @param int $port | ||
| */ | ||
| function socket_getpeername(Socket $socket, &$address, &$port = null): bool {} | ||
| function socket_getpeername(Socket $socket, &$address, ?int &$objint = null): bool {} |
There was a problem hiding this comment.
This is a BC break due to named parameters
There was a problem hiding this comment.
Do you mean UPGRADING entry ?
There was a problem hiding this comment.
I just wanted to make sure that you noticed the breaking change: existing code like socket_getpeername($socket, $address, port: $port) will stop working.
I'm not sure what our policy is regarding those, but I think that sending an email to internals to check for objections would be worth it.
devnexen
force-pushed
the
socket_ether_linux
branch
2 times, most recently
from
cf003e7 to
f27a478
Compare
devnexen
force-pushed
the
socket_ether_linux
branch
from
f27a478 to
9f2b2f3
Compare
arnaud-lb
approved these changes
Jan 30, 2025
|
Yes that s, at least, a 3 parts plan, this is just to TODO list. But I can always remove these if that s really an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.