Drop --with-uncritical-warn-choke configuration option #17554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
approved these changes
Jan 24, 2025
Besides the POSIX function names (which we likely want to ignore), the Unsafe CRT Library functions (which we probably want to address), and some WinSock deprecations (locally suppressed by |
This selection of suppressed warnings is pretty arbitrary, and apparently disabling it does not raise any more warning for whole php-src (except for `-Wno-deprecated-declarations`). As such it appears to be pretty useless, and it seems to be more appropriate to let users select which warnings to suppress via manually set `CFLAGS`. Since we already apply `/wd4996`[1] when building with MSVC, and there are indeed plenty of deprecation warnings, for now, we apply `-Wno-deprecated-declarations` for Clang builds unconditionally. [1] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996>
cmb69
force-pushed
the
cmb/drop-uncritical-warn-choke
branch
from
a374aef to
fe4dcfd
Compare
Oops, totally forgot to commit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This selection of suppressed warnings is pretty arbitrary, and apparently disabling it does not raise any more warning for whole php-src (except for
-Wno-deprecated-declarations). As such it appears to be pretty useless, and it seems to be more appropriate to let users select which warnings to suppress via manually setCFLAGS.Since we already apply
/wd4996[1] when building with MSVC, and there are indeed plenty of deprecation warnings, for now, we apply-Wno-deprecated-declarationsfor Clang builds unconditionally.[1] https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996
Note that I'm planning to have a closer look at the deprecations soon. It seems it's possible to just suppress some of these (such as the deprecated POSIX function names) by setting some compile time flags, which appears to a be nice improvement over suppressing all deprecation warnings.