-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for phpstan/phpdoc-parser 2 #386
Conversation
68fba0f
to
aea9739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your help to upgrade, I think we should accept the issues in the pipeline by adding the phpstan errors to the baseline. And add the missing symbol to the composer-require-checker config.
Let me know if you need any help with that.
['lines' => true, 'indexes' => true], | ||
true | ||
); | ||
if (class_exists(ParserConfig::class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add class_exists
as a use function class_exists
this will fix the codestyle issue in the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaapio Could you retrigger the build? I hope I caught everything. :)
aea9739
to
0e5d1e0
Compare
0e5d1e0
to
2a8b28d
Compare
Thanks a lot, I will take care of the last code style issue, don't worry about that one. :-) |
so....... Symfony 7.1 stable project.... composer update... BANG 💣
Its cool, I just pegged the old version for now until I understand whats going on here...
Not looking for support, just thought it was imporant to note that a straight composer update broken me and made me cry... more coffee needed. Hugs needed. haha. |
Coffee cup filled... I note that symfony/type-info is the problem here. I see you already have submitted the changes symfony/type-info@51535dd but they are not released yet. also symfony/property-info at symfony/property-info@4d77ab2 Hope that helps the next person coming here :) and @fabpot might release a new version soon of symfony/type-info and symfony/property-info. for today I have switched to
|
Yes, the next Symfony patch releases will indeed be compatible with |
Its all cool... appreciate your work. Could not find a way to send you money though, consider enabling GitHub sponsors! :) |
Hello, thanks for the patch but the new release breaks APIP:
|
I think the problem is api-platform relies on a specific version but does not enforce it directly? Otherwise composer would have blocked the install. |
Yes, that's indeed the cause. API Platform does not restrict the installation of |
No description provided.