fix #112 - EPV doesn't work with PHP 8

[Skouat]

From Titania, when we submit a revision and Titania runs under PHP8, EPV fails with the following message:

[phpBB Debug] PHP Warning
: in file
[ROOT]/ext/phpbb/titania/vendor/nikic/php-parser/lib/PhpParser/Lexer.php
on line
258
:
Undefined array key 265

[phpBB Debug] PHP Warning
: in file
[ROOT]/ext/phpbb/titania/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php
on line
190
:
Undefined array key ""

[phpBB Debug] PHP Warning
: in file
[ROOT]/ext/phpbb/titania/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php
on line
359
:
Undefined array key ""

Upgrading nikic/php-parser to version 4 fix this issue, and also the issue #112

[private-packagist]

composer.lock

Click to show 52 changes in this composer.lock file

Package changes

Package	Operation	From	To	About
symfony/deprecation-contracts	add	-	v2.5.3	view code - License: MIT License
symfony/polyfill-intl-grapheme	add	-	v1.31.0	view code - License: MIT License
symfony/polyfill-intl-normalizer	add	-	v1.31.0	view code - License: MIT License
symfony/string	add	-	v5.4.44	view code - License: MIT License
composer/ca-bundle	upgrade	1.3.1	1.5.2	diff
composer/composer	upgrade	1.10.26 ⚠️	1.10.27 ✅	diff
composer/spdx-licenses	upgrade	1.5.6	1.5.8	diff
gitonomy/gitlib	upgrade	v0.1.8	v1.3.8	diff
justinrainbow/json-schema	upgrade	5.2.12	5.3.0	diff
nikic/php-parser	upgrade	v3.1.5	v4.19.4	diff
psr/container	upgrade	1.0.0	1.1.1	diff
seld/jsonlint	upgrade	1.9.0	1.11.0	diff
seld/phar-utils	upgrade	1.2.0	1.2.1	diff
symfony/console	upgrade	v4.4.16	v5.4.44	diff
symfony/filesystem	upgrade	v5.4.7	v5.4.44	diff
symfony/finder	upgrade	v5.1.8	v5.4.43	diff
symfony/polyfill-ctype	upgrade	v1.25.0	v1.31.0	diff
symfony/polyfill-mbstring	upgrade	v1.20.0	v1.31.0	diff
symfony/polyfill-php73	upgrade	v1.20.0	v1.31.0	diff
symfony/polyfill-php80	upgrade	v1.25.0	v1.31.0	diff
symfony/process	upgrade	v3.4.46	v5.4.44	diff
symfony/service-contracts	upgrade	v2.2.0	v2.5.3	diff
symfony/yaml	upgrade	v4.4.16	v5.4.44	diff

Dev Package changes

Package	Operation	From	To	About
phar-io/manifest	add	-	2.0.4	view code - License: BSD 3-Clause "New" or "Revised" License
phar-io/version	add	-	3.2.1	view code - License: BSD 3-Clause "New" or "Revised" License
sebastian/object-reflector	add	-	1.1.3	view code - License: BSD 3-Clause "New" or "Revised" License
sebastian/type	add	-	1.1.5	view code - License: BSD 3-Clause "New" or "Revised" License
theseer/tokenizer	add	-	1.2.3	view code - License: BSD 3-Clause "New" or "Revised" License
doctrine/instantiator	upgrade	1.4.0	1.5.0	diff
myclabs/deep-copy	upgrade	1.10.2	1.12.0	diff
phpunit/php-code-coverage	upgrade	4.0.8	7.0.17	diff
phpunit/php-file-iterator	upgrade	1.4.5	2.0.6	diff
phpunit/php-timer	upgrade	1.0.9	2.1.4	diff
phpunit/php-token-stream	upgrade	2.0.2	3.1.3	diff
phpunit/phpunit	upgrade	5.7.27	8.5.40	diff
sebastian/code-unit-reverse-lookup	upgrade	1.0.1	1.0.3	diff
sebastian/comparator	upgrade	1.2.4	3.0.5	diff
sebastian/diff	upgrade	1.4.3	3.0.6	diff
sebastian/environment	upgrade	2.0.0	4.2.5	diff
sebastian/exporter	upgrade	2.0.0	3.1.6	diff
sebastian/global-state	upgrade	1.1.1	3.0.5	diff
sebastian/object-enumerator	upgrade	2.0.1	3.0.5	diff
sebastian/recursion-context	upgrade	2.0.0	3.0.2	diff
sebastian/resource-operations	upgrade	1.0.0	2.0.3	diff
phpdocumentor/reflection-common	remove	2.2.0	-	-
phpdocumentor/reflection-docblock	remove	5.2.2	-	-
phpdocumentor/type-resolver	remove	1.4.0	-	-
phpspec/prophecy	remove	v1.10.3	-	-
phpunit/phpunit-mock-objects	remove	3.4.4	-	-
webmozart/assert	remove	1.9.1	-	-

Important Metadata Changes

Package	Version	Metadata	From	To
justinrainbow/json-schema	5.3.0	dist url	https://api.github.com/repos/justinrainbow/json-schema/zipball/ad87d5a5ca981228e0e205c2bc7dfb8e24559b60	https://api.github.com/repos/jsonrainbow/json-schema/zipball/feb2ca6dd1cebdaf1ed60a4c8de2e53ce11c4fd8
justinrainbow/json-schema	5.3.0	source url	https://github.com/justinrainbow/json-schema.git	https://github.com/jsonrainbow/json-schema.git

---

Settings · Docs · Powered by Private Packagist

[paul999]

@Skouat But does it still work correctly? Looking at the tests a bunch of them fail now, which didn't happen in the past. It would also be nice if we run it at least on 1 php8 version on GitHub.

We also will need to have it both php7 and php8 compatible.

[Skouat]

Hi @paul999

Looking at the tests a bunch of them fail now, which didn't happen in the past.

Please, take on look on the PR #111. It fails. So maybe the issue is on an higher level and not due to my PR.

also be nice if we run it at least on 1 php8 version on GitHub.

We also will need to have it both php7 and php8 compatible.

Sure. I can check this.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[private-packagist]

The composer.lock diff comment has been updated to reflect new changes in this PR.

[Skouat]

@paul999 Normally, now it works with PHP 7 and PHP 8

[iMattPro]

I think the test runner needs to be updated to run on ubuntu-22.04

[Skouat]

Your master branch use ubuntu-latest.
Can you confirm I can force ubuntu-22.04?

[Skouat]

@paul999 Finally, I rebased my branch to use your latest test runner config file.

[paul999]

Thanks a lot @Skouat! I will try to have this tested later this week, to make sure it also works with titania on phpbb.com

[Skouat]

Hi @paul999

EPV cannot be installed on Titania via composer.
This is not due to EPV, but because Titania uses Chumper/Zipper, which is abandoned and depends on Symfony 4.2.

[Skouat]

MR to remove Zipper: phpbb/customisation-db#395