Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated nullable areguments #624 #625

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix deprecated nullable areguments #624 #625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions spec/Prophecy/Doubler/Generator/ClassCodeGeneratorSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ function it_generates_proper_php_code_for_specific_ClassNode(
$method5->getCode()->willReturn('return;');

$argument11->getName()->willReturn('fullname');
$argument11->isOptional()->willReturn(true);
$argument11->getDefault()->willReturn(null);
$argument11->isOptional()->willReturn(false);
$argument11->isPassedByReference()->willReturn(false);
$argument11->isVariadic()->willReturn(false);
$argument11->getTypeNode()->willReturn(new ArgumentTypeNode('array'));
Expand Down Expand Up @@ -116,7 +115,7 @@ class CustomClass extends \RuntimeException implements \Prophecy\Doubler\Generat
public $name;
private $email;

public static function getName(array $fullname = NULL, \ReflectionClass $class, object $instance): ?string {
public static function getName(array $fullname, \ReflectionClass $class, object $instance): ?string {
return $this->name;
}
protected function getEmail(?string $default = '[email protected]') {
Expand Down Expand Up @@ -265,14 +264,14 @@ function it_overrides_properly_methods_with_args_passed_by_reference(
$argument->getDefault()->willReturn(null);
$argument->isPassedByReference()->willReturn(true);
$argument->isVariadic()->willReturn(false);
$argument->getTypeNode()->willReturn(new ArgumentTypeNode('array'));
$argument->getTypeNode()->willReturn(new ArgumentTypeNode('array', 'null'));

$code = $this->generate('CustomClass', $class);
$expected = <<<'PHP'
namespace {
class CustomClass extends \RuntimeException implements \Prophecy\Doubler\Generator\MirroredInterface {

public function getName(array &$fullname = NULL) {
public function getName(?array &$fullname = NULL) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof this changes still required to prevent deprecations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR to keep only the required changes ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! looking for unblocking release)

return $this->name;
}

Expand Down