Fixes after PHPStan update

phpstan · Sep 24, 2024 · 674c9d4 · 674c9d4
1 parent d45a640
commit 674c9d4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 12 deletions.
diff --git a/src/Type/Doctrine/Descriptors/SimpleArrayType.php b/src/Type/Doctrine/Descriptors/SimpleArrayType.php
@@ -8,6 +8,7 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
 
 class SimpleArrayType implements DoctrineTypeDescriptor
 {
@@ -19,7 +20,7 @@ public function getType(): string
 
 	public function getWritableToPropertyType(): Type
 	{
-		return AccessoryArrayListType::intersectWith(new ArrayType(new IntegerType(), new StringType()));
+		return TypeCombinator::intersect(new ArrayType(new IntegerType(), new StringType()), new AccessoryArrayListType());
 	}
 
 	public function getWritableToDatabaseType(): Type

diff --git a/src/Type/Doctrine/HydrationModeReturnTypeResolver.php b/src/Type/Doctrine/HydrationModeReturnTypeResolver.php
@@ -77,10 +77,10 @@ public function getMethodReturnTypeForHydrationMode(
 				);
 			default:
 				if ($queryKeyType->isNull()->yes()) {
-					return AccessoryArrayListType::intersectWith(new ArrayType(
+					return TypeCombinator::intersect(new ArrayType(
 						new IntegerType(),
 						$queryResultType,
-					));
+					), new AccessoryArrayListType());
 				}
 				return new ArrayType(
 					$queryKeyType,

diff --git a/tests/Platform/data/config.neon b/tests/Platform/data/config.neon
@@ -1,5 +1,2 @@
 includes:
 	- ../../../extension.neon
-parameters:
-	featureToggles:
-		listType: true
diff --git a/tests/Type/Doctrine/Query/QueryResultTypeWalkerHydrationModeTest.php b/tests/Type/Doctrine/Query/QueryResultTypeWalkerHydrationModeTest.php
@@ -116,8 +116,6 @@ public function test(Type $expectedType, string $dql, string $methodName, ?int $
 	 */
 	public static function getTestData(): iterable
 	{
-		AccessoryArrayListType::setListTypeEnabled(true);
-
 		yield 'getResult(object), full entity' => [
 			self::list(new ObjectType(Simple::class)),
 			'
@@ -305,7 +303,7 @@ private static function constantArray(array $elements): Type
 
 	private static function list(Type $values): Type
 	{
-		return AccessoryArrayListType::intersectWith(new ArrayType(new IntegerType(), $values));
+		return TypeCombinator::intersect(new ArrayType(new IntegerType(), $values), new AccessoryArrayListType());
 	}
 
 	private static function numericString(): Type

diff --git a/tests/Type/Doctrine/Query/QueryResultTypeWalkerTest.php b/tests/Type/Doctrine/Query/QueryResultTypeWalkerTest.php
@@ -1497,7 +1497,7 @@ private function yieldConditionalDataset(): iterable
 					$this->constantArray([
 						[new ConstantStringType('stringEnumColumn'), new ObjectType(StringEnum::class)],
 						[new ConstantStringType('intEnumColumn'), new ObjectType(IntEnum::class)],
-						[new ConstantStringType('stringEnumListColumn'), AccessoryArrayListType::intersectWith(new ArrayType(new IntegerType(), new ObjectType(StringEnum::class)))],
+						[new ConstantStringType('stringEnumListColumn'), TypeCombinator::intersect(new ArrayType(new IntegerType(), new ObjectType(StringEnum::class)), new AccessoryArrayListType())],
 					]),
 					'
 						SELECT		e.stringEnumColumn, e.intEnumColumn, e.stringEnumListColumn

diff --git a/tests/Type/Doctrine/data/QueryResult/config.neon b/tests/Type/Doctrine/data/QueryResult/config.neon
@@ -3,5 +3,3 @@ includes:
 parameters:
 	doctrine:
 		objectManagerLoader: entity-manager.php
-	featureToggles:
-		listType: true