Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests #25

Open
OleMchls opened this issue Oct 8, 2013 · 12 comments
Open

Unittests #25

OleMchls opened this issue Oct 8, 2013 · 12 comments

Comments

@OleMchls
Copy link
Member

OleMchls commented Oct 8, 2013

I guess this will never happen but would be super awesome ❤️

@OleMchls
Copy link
Member Author

OleMchls commented Oct 8, 2013

travis? 👍

@ClemensSahs
Copy link

yes travis!

I currently don't have the environment to tests this local. If anyone have suggestion to solve the building error than we have a running test case.
travis
branch

until this evening

@OleMchls
Copy link
Member Author

Looks cool! Maybe we can help to get it running on your machine. What's missing?

@ClemensSahs
Copy link

@Nesquick
This is nice but a environment on this machine... this will never happen under a broken OS. And the machine is not strong enough to handle virtual machines too.

Back to topic:
I solve the building error and see now that the server is not running, perhaps anyone have a Idea.

doku say that we can run with --detach or -B

task :travis do
  system "jekyll serve --detach --port 4000"
end # task :travis

@OleMchls
Copy link
Member Author

Could you add a section in README.md how to run the tests?

My only concern is what this setup is a bit complex, what do we need grunt for? Maybe you could explain what's happening there. I would like to help you with this, but I don't see the latest travis build nor am I able to get this running on my machine.

@ClemensSahs
Copy link

Grunt is the only way I found to call node.js tests directly, if we can call the JS tests directly its better than my currently solution. I search only a few minuets for this solution.
Alternative I found selenium on ruby, this setup is not so complex.

Yes I can add this in to readme.md but in front of this I this stuff finished.

@ClemensSahs
Copy link

all my builds you found on travis

@ClemensSahs
Copy link

@Nesquick
now we have green tests

https://travis-ci.org/ClemensSahs/phpughh.github.com/builds/15333301

I rebase this and send a PR

@icewolfs
Copy link
Member

@ClemensSahs @Nesquick awesome!

@OleMchls
Copy link
Member Author

@ClemensSahs Thanks a lot! I will check this out en details to see if we can get rid of grunt and simplify the setup. But again, thank you very much for adding this 👍

So is this the current branch? https://github.com/ClemensSahs/phpughh.github.com/compare/feature;travis_2

Could your write one or two sentences what's happening and how to set it up?

@ClemensSahs
Copy link

@Nesquick
yes readme is in my todo list ;)
no currently i rebase the history and pushing this up currently

branch: feature/travis
Build Status

I send PR now ;) readme will follow sone as possible

@OleMchls
Copy link
Member Author

yep, lets continue this at the PR 😃

#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants