Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] unittests with travis #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ClemensSahs
Copy link

issue #25

todo

  • readme
  • reasons for this setup
  • simplify the setup if we can

@OleMchls
Copy link
Member

To simplify things I proposed the easier way of life here: ClemensSahs#1

What do you think?

@@ -2,7 +2,7 @@
# For more see: https://github.com/mojombo/jekyll/wiki/Permalinks
permalink: /:categories/:year/:month/:day/:title

exclude: [".rvmrc", ".rbenv-version", "README.md", "Rakefile", "changelog.md"]
exclude: [".rvmrc", ".rbenv-version", "README.md", "Rakefile", "changelog.md","vendor"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this vendor directory contain?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this we need to fix the building error

bundle exec rake travis or easier bundle exec jekyll serve --detach --port 4000

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question is, if we can get rid of this change when we killed grunt and npm? I would like to know who (which script) creates this dir

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry for write this unclear.

this directory will create by bundle install --deployment

Generating... Error reading file /home/travis/build/ClemensSahs/phpughh.github.com/vendor/bundle/ruby/1.9.1/gems/RedCloth-4.2.9/spec/fixtures/lists.yml: Don't know how to add to a NilClass!

This we need to build the the page with jekyll serve.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, right. Then it have to stay obviously 🐳

@OleMchls OleMchls mentioned this pull request Dec 12, 2013
@ClemensSahs
Copy link
Author

@Nesquick
your patch looks really nice, I will merge this soon as possible.

I will look how we can hide the requested URL's else we have with 10 tests N log lines in travis.

@OleMchls
Copy link
Member

great. So lets see how this PR looks like when this ClemensSahs#1 is merged - I guess we are good to go then. Just addings some docs and beautify the output

@glaubinix
Copy link
Member

any updates here @ClemensSahs?

remove unneccessary modules and installers
@ClemensSahs
Copy link
Author

sry guy's I was very busy the last weeks. Now I have some more time.
@Nesquick
Currently I try clean the output.

  • log level don't work hide this
  • pipe to /dev/null for casperjs and jekyll are useless

I think the request URI come from phantomjs, currently I have no solution for that. Has somebody a idea?

@OleMchls
Copy link
Member

OleMchls commented Feb 7, 2014

@ClemensSahs could you please again just post the url for us? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants