-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track and prioritize routing according to application restart generations #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FooBarWidget
requested changes
Sep 17, 2024
48f430d
to
187b804
Compare
not that there’s a point in this test really
187b804
to
a376e8e
Compare
[ci skip] [ci:skip]
4a9b0ed
to
6b739f3
Compare
FooBarWidget
requested changes
Oct 3, 2024
FooBarWidget
reviewed
Oct 3, 2024
FooBarWidget
reviewed
Oct 3, 2024
899ac69
to
6ab1b52
Compare
80604b6
to
b40c7d2
Compare
[ci skip]
[ci skip]
[ci skip]
5d9e371
to
8a5ebc3
Compare
The tests that failed in the last run were due to the cache step failing, I reran them and they passed. |
All requested changes have been made. |
[ci skip] [ci:skip]
[ci skip]
FooBarWidget
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation number groups all application processes according to the most recent restart initiation. We use this information to intelligently route to newer generations if there is capacity.
Fixes one aspect of #2551.