Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ?property formula (part 2), complete deduction #208

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

yhx-12243
Copy link
Contributor

@yhx-12243 yhx-12243 commented Dec 10, 2024

Continuation of #206.

See #206 (comment) for details.

@StevenClontz
Copy link
Member

Preview at https://pr208.topology.pages.dev/

@prabau
Copy link

prabau commented Dec 10, 2024

Better.

Related to the implication [ LOTS + Perfectly normal => First countable ]:

(1) π-Base, Search for LOTS + ?Perfectly normal + ~First countable

returns "... is impossible". As discussed before, it's not immediately clear what is impossible, but the users just have to replace "?P" with "P" and "~P" and they will be told which one of the two is impossible.

(2) π-Base, Search for ?LOTS + Perfectly normal + ~First countable

It should be "... is impossible", but for some reason that is not detected. Probably due to the limitations of the deduction engine, as you mentioned.

@StevenClontz
Copy link
Member

e2e tests are just broken, so ignoring that.

This is a strict improvement, so merging.

@StevenClontz StevenClontz merged commit c0f7179 into pi-base:main Dec 12, 2024
2 of 3 checks passed
@yhx-12243 yhx-12243 deleted the question-property-p2 branch December 13, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants