Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw derived proofs #81

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draw derived proofs #81

wants to merge 1 commit into from

Conversation

jamesdabbs
Copy link
Member

@jamesdabbs jamesdabbs commented Nov 12, 2023

Updates the derived trait display to visually present the overall proof

Screenshot 2023-11-13 at 6 55 59 AM Hovering a node or edge highlights the corresponding property or theorem

Several examples of varying complexity:

We can iterate and tweak this indefinitely. I have a few TODOs I'd like to at least look at before moving this out of draft as a v1:

  • improve layout, handle resizing
  • ensure nodes don't escape bounding box
  • align graph towards top of panel
  • pick an apply a stable color scheme
  • add tests to cover the new .ts code

Questions

  • Hows the general layout and interactivity? Any suggestions?
  • We talked about trying to improve the existing theorems list, through a mix of "collapsing" chains of implications that are straight lines, and sorting them in a more natural order. Looking at this one – I'm struggling to put together a reasonable algorithm for how those theorems should be sorted and grouped. Any suggestions? (Forget for a second that Discrete => T1, and that the proof is overcomplicated Reduce derived proofs #82)

@jamesdabbs jamesdabbs self-assigned this Nov 12, 2023
Copy link

cloudflare-workers-and-pages bot commented Nov 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb2ae8c
Status: ✅  Deploy successful!
Preview URL: https://8920baa8.topology.pages.dev
Branch Preview URL: https://graph.topology.pages.dev

View logs

@jamesdabbs jamesdabbs changed the title wip Draw derived proofs Nov 13, 2023
@StevenClontz
Copy link
Member

Looking at this one – I'm struggling to put together a reasonable algorithm for how those theorems should be sorted and grouped. Any suggestions?

I think the more important thing is that users can manually manipulate the graph and get the picture they need to grok what's going on, not to mention to take a screenshot of (or export to a vector file?) for inclusion in their paper or MathOverflow post.

@StevenClontz
Copy link
Member

Other hot takes:

  • I don't think the distinction of blue nodes is very helpful: I'm spending a lot of time carefully hovering over the tiny circle to see the pop-up text.
  • Could we add Txyz to each edge in addition to hover support?
  • It'd be very helpful if true properties were colored differently than false properties.
  • I don't think fixing the consequent in place is helpful.
  • See also my comments at Reduce derived proofs #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants