This repository has been archived by the owner on Mar 2, 2020. It is now read-only.
ldap authentication #233
Open
ldap authentication #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureMarker
suggested changes
Oct 7, 2019
AzureMarker
suggested changes
Oct 7, 2019
| # Statically link SQLite (use the crate version provided by Diesel) | ||
| # The highest version which Diesel currently allows is 0.12.0 | ||
| libsqlite3-sys = { version = "0.12.0", features = ["bundled"] } | ||
| ldap3 = "0.6.1" |
There was a problem hiding this comment.
This transitively adds a requirement on OpenSSL, which needs some native bindings. The docker build containers will need to be updated to support this requirement.
AzureMarker
suggested changes
Oct 9, 2019
cyberb
force-pushed
the
development
branch
2 times, most recently
from
0d24cdf
to
81219b1
Compare
AzureMarker
reviewed
Oct 12, 2019
AzureMarker
suggested changes
Oct 12, 2019
|
I'm currently working on adding the required OpenSSL libraries to the Docker containers, in addition to updating the Rust version. I will make a PR for this and after it's merged you can rebase on development to fix this PR's compilation issues. |
|
@cyberb Can you put the new dependencies and LDAP code behind a feature flag? |
cyberb
force-pushed
the
development
branch
3 times, most recently
from
6cd7139
to
410c9fd
Compare
Signed-off-by: Boris Rybalkin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to get your feedback on this.
Keep in mind this is my first rust experience.
At the moment my web fork sends plain text two headers username and key (password).
There are two options on how it can decide what mode to use (one or two auth fields to show) either by calling api auth_mode url (not implemented yet) or by checking its own config (not ideal).