Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bake debugging requirements into the nightly image for ease of debugging #1675

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 28, 2024

Description

See title, the instructions are in taken from https://deploy-preview-338--pihole-docs.netlify.app/ftldns/gdb/

Motivation and Context

Related to pi-hole/FTL#2112 (comment)

How Has This Been Tested?

Locally build container, confirmed gdb is working. The image increases quite significantly in size which is why I am not suggesting this for any production, just the hard development tag. I added the installation rather early to benefit from Docker's cache so changes due to a more recent FTL binary, etc., do not need to download much.

$ docker images
REPOSITORY           TAG               IMAGE ID       CREATED          SIZE
<none>               nightly           59b8682afb79   7 seconds ago    144MB
<none>               local             c888fe0ab5a6   36 seconds ago   91.2MB

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@DL6ER DL6ER merged commit 7acd0d4 into development Dec 28, 2024
6 checks passed
@DL6ER DL6ER deleted the new/debug_at_night branch December 28, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants