Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-937: Update dependencies and TV improvements #48

Merged
merged 6 commits into from
Nov 16, 2023
Merged

PIA-937: Update dependencies and TV improvements #48

merged 6 commits into from
Nov 16, 2023

Conversation

kp-juan-docal
Copy link
Contributor

Summary

@kp-iva-nedeleva I've separated it into different commits to hopefully ease the review burden, and have a bit of a scope in case there are questions.

  • It updates all dependencies to the latest when possible. This means we are not updating gradle or android tools as it will force us to move away from ButterKnife, which translates into a rewire of all UI.
  • It validates that the fetching of the regions list or update of latencies happens for logged-in users only.
  • It fixes a minor issue with the theming when opening the application on TV.

Sanity Tests

  • Open the app. Connect to any region using Wireguard. Confirm it succeeds.
  • Open the app. Connect to any region using OpenVPN. Confirm it succeeds.
  • On mobile. Change the theme. Confirm it is applied properly.
  • On TV. Open app. Confirm the theme doesn't toggle when launching.
  • On TV. Open app. Confirm we enter the login screen with no subscriptions.

@kp-juan-docal kp-juan-docal self-assigned this Nov 15, 2023
kp-iva-nedeleva
kp-iva-nedeleva approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit 556286a into master Nov 16, 2023
3 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/firestick branch November 16, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-iva-nedeleva kp-iva-nedeleva kp-iva-nedeleva approved these changes

@kp-aldo-pedromingo kp-aldo-pedromingo Awaiting requested review from kp-aldo-pedromingo kp-aldo-pedromingo is a code owner

Assignees

@kp-juan-docal kp-juan-docal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-juan-docal @kp-iva-nedeleva