Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-955: Show the per-app settings option on Android TV for both protocols #51

Merged
merged 1 commit into from
Nov 23, 2023
Merged

PIA-955: Show the per-app settings option on Android TV for both protocols #51

merged 1 commit into from
Nov 23, 2023

Conversation

kp-juan-docal
Copy link
Contributor

@kp-juan-docal kp-juan-docal commented Nov 22, 2023 •
edited
Loading

Summary

As per title. We are now showing the per-app settings option for both VPN protocols.

Sanity Tests

  • Open App. Confirm the option present for OpenVPN.
  • After the above. Change to Wireguard. Confirm the option present for Wireguard.
  • After the above. Connect to any region. Go to PIA's what-is-my-ip website. Confirm it shows protected.
  • After the above. Disconnect. Go to per-app settings and uncheck the browser. Connect to any region. Go to PIA's what-is-my-ip website. Confirm it shows unprotected.

@kp-juan-docal kp-juan-docal self-assigned this Nov 22, 2023
kp-iva-nedeleva
kp-iva-nedeleva approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit 9393c12 into master Nov 23, 2023
3 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-955-show-per-app-setting-on-tv-for-both-protocols branch November 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-iva-nedeleva kp-iva-nedeleva kp-iva-nedeleva approved these changes

@kp-aldo-pedromingo kp-aldo-pedromingo Awaiting requested review from kp-aldo-pedromingo kp-aldo-pedromingo is a code owner

Assignees

@kp-juan-docal kp-juan-docal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-juan-docal @kp-iva-nedeleva