PIA-1290: Fix illegal state exception on signup flow #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-juan-docal
requested review from
kp-iva-nedeleva and
kp-aldo-pedromingo
as code owners
kp-juan-docal
deleted the
juan.docal/PIA-1290-fix-illegal-state-exception-on-signup-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It allows for the loss of state on the login screen as otherwise an exception would be thrown on edge cases, where we are trying to commit the transaction after a state saved has occurred. Given that we are not interested in saving the state of the login screen, let it be dropped instead of crashing.
Sanity Tests