Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-1361: Fix margin issue in the email purchase fragment #71

Conversation

kp-juan-docal
Copy link
Contributor

Summary

It fixes the issue by moving the margin as padding of the container, rather than defining it on each element.

Sanity Tests

  • Navigate to the affected fragment. Confirm the margin is applied to all elements.

Copy link
Collaborator

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit df8352b into master Feb 19, 2024
3 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-1361-fix-margin-issue-on-email-purchase-email-fragment branch February 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants