Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-1187: Make ping result list synchronized #13

Merged
merged 4 commits into from
Jan 15, 2024
Merged

PIA-1187: Make ping result list synchronized #13

merged 4 commits into from
Jan 15, 2024

Conversation

kp-juan-docal
Copy link
Contributor

Summary

It updates the list containing the ping results to be synchronized as all pings are being invoked concurrently, which is causing a race conditions on add causing for some results to be added as null.

Sanity Tests

  • Make a local release. Import it on the legacy app. Confirm we can't reproduce the issue with pings not returning the callback.
  • Make a local release. Import it on the re-arch app. Confirm we can't reproduce the issue with pings not returning the callback.

@kp-juan-docal kp-juan-docal self-assigned this Jan 12, 2024
kp-aldo-pedromingo
kp-aldo-pedromingo approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@kp-aldo-pedromingo kp-aldo-pedromingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kp-juan-docal kp-juan-docal merged commit f2053de into master Jan 15, 2024
2 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-1187-make-ping-list-synchronized branch January 15, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-aldo-pedromingo kp-aldo-pedromingo kp-aldo-pedromingo approved these changes

Assignees

@kp-juan-docal kp-juan-docal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-juan-docal @kp-aldo-pedromingo