Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-839: Add region's iso within the shadowsocks server response #15

Conversation

kp-juan-docal
Copy link
Contributor

Summary

We need to expose the region iso in order to be able to show the appropiate region flag within the client.

Sanity Test

  • Use a version of the library containing these changes with the client. Confirm we can map the flags accordingly.

Copy link

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit 2407a51 into master Jan 24, 2024
2 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-839-expose-region-iso-in-shadowsocks-server-object branch January 24, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants