Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-1900: Ping just one meta endpoint per region #17

Merged

Conversation

kp-juan-docal
Copy link
Contributor

@kp-juan-docal kp-juan-docal commented Jun 5, 2024

Summary

As per title. It updates the ping logic to ping just one meta endpoint per region instead of all of them as we only need the latency per region, not per server. This would also help reduce the amount of network noise related to it.

Sanity Tests

  • Using the previous logic. Add some logs to get the number of ping requests. With the current response, that number is 349
  • Using this logic. Add some logs to get the number of ping requests. With the current response, that number is 166. Which is around the number of regions we support.

Copy link

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit f437ad9 into master Jun 5, 2024
2 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-1900-ping-one-endpoint-per-region branch June 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants